Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ext/node): migrate back to using "Deno.serve" API for HTTP server #18865

Merged
merged 13 commits into from
Apr 27, 2023
Merged

refactor(ext/node): migrate back to using "Deno.serve" API for HTTP server #18865

merged 13 commits into from
Apr 27, 2023
+62 −86

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Apr 26, 2023 •
edited
Loading

This commit fixes "node:http" API to properly handle "upgrade"
requests and thus marking Vite work again.

This is done by migrating back to "Deno.serve()" and internal "upgradeHttpRaw"
APIs for "node:http" module polyfill.

This was referenced Apr 26, 2023
Merged
Closed
@bartlomieju bartlomieju marked this pull request as ready for review April 26, 2023 23:21
mmastrac
mmastrac approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 1e331a4 into denoland:main Apr 27, 2023
@bartlomieju bartlomieju deleted the http_node branch April 27, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@kt3k kt3k Awaiting requested review from kt3k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @mmastrac